When system calls indicate an error they return -1, not some arbitrary
value < 0. errno is only updated in this case. Change all (most?)
callers of syscalls to follow this better, and let's see if

When system calls indicate an error they return -1, not some arbitrary
value < 0. errno is only updated in this case. Change all (most?)
callers of syscalls to follow this better, and let's see if this strictness
helps us in the future.

show more ...

Delete useless setlocale(3) in src/bin/.
Minor cleanup while here: return from main, static void __dead usage, etc.
Based on a patch from Jan Stary <hans at stare dot cz>.
Feedback and OK tb@, OK mil

Delete useless setlocale(3) in src/bin/.
Minor cleanup while here: return from main, static void __dead usage, etc.
Based on a patch from Jan Stary <hans at stare dot cz>.
Feedback and OK tb@, OK millert@.

show more ...

correct precedence; from Ilya Kaliman

normalize the ordering of tame requests (particularily, "rpath wpath cpath",
which i have put in that order). this is not important, but helps look
for outliers which might be strange. it hints that

normalize the ordering of tame requests (particularily, "rpath wpath cpath",
which i have put in that order). this is not important, but helps look
for outliers which might be strange. it hints that "ioctl" should be
reassessed in a few places, to see if "tty" is better; that "unix" may
be used in some places where "route" could now work.

show more ...

Change all tame callers to namechange to pledge(2).

tame "stdio cpath rpath fattr", unless mkdir -m is passed a mode which
has setuid/setgid/sticky bits.
ok semarie

Revert rev 1.21 to fix a race condition where multiple mkdir -p's trying
to create overlapping paths in parallel could error out. ok millert@

rcsid[] and sccsid[] and copyright[] are essentially unmaintained (and
unmaintainable). these days, people use source. these id's do not provide
any benefit, and do hurt the small install media
(th

rcsid[] and sccsid[] and copyright[] are essentially unmaintained (and
unmaintainable). these days, people use source. these id's do not provide
any benefit, and do hurt the small install media
(the 33,000 line diff is essentially mechanical)
ok with the idea millert, ok dms

show more ...

Fix a problem in the last commit. Upon closer reading of POSIX, in
-p mode we only want to change the mode on directories we actually created.

Fix "-m mode" in conjunction with the -p flag. Also simplify the error
handling. Closes PR 5908. OK deraadt@

Rework the fix in 1.20. The original fix causes problems for systrace
policies since mkdir(2) will be called for each directory in the path,
even things like / or /usr. We now use a hybrid approach

Rework the fix in 1.20. The original fix causes problems for systrace
policies since mkdir(2) will be called for each directory in the path,
even things like / or /usr. We now use a hybrid approach uses stat(2)
until either we find something missing or we reach that last component.
Then we switch to calling mkdir(). Tested by bernd@ and chl@

show more ...

fix PR 5141:
race condition in mkdir -p that may lead to an erroneous successful exit status.

reported by Ralf Wildenhues <Ralf.Wildenhues at gmx.de>

fix based on a suggested patch by Bruno Carnazz

fix PR 5141:
race condition in mkdir -p that may lead to an erroneous successful exit status.

reported by Ralf Wildenhues <Ralf.Wildenhues at gmx.de>

fix based on a suggested patch by Bruno Carnazzi <bcarnazzi at gmail.com>,
largely inspired by NetBSD mkdir()s implementation

looks OK otto@ OK millert@

show more ...

the ellipsis is not an optional argument; while here, sync the usage
and synopsis of commands

lots of good ideas by jmc@

ok jmc@

Make sure `path' variable is always NUL-terminated.

Totally different diff (but functionally equivalent) by Loic Tortay
and okayed by tedu@.

``Looks sane to me'' moritz@

setmode(3) returns void *, not mode_t *. ok millert@

spacing

Remove the advertising clause in the UCB license which Berkeley
rescinded 22 July 1999. Proofed by myself and Theo.

ansi

knf

Part one of userland __P removal. Done with a simple regexp with some minor hand editing to make comments line up correctly. Another pass is forthcoming that handles the cases that could not be don

Part one of userland __P removal. Done with a simple regexp with some minor hand editing to make comments line up correctly. Another pass is forthcoming that handles the cases that could not be done automatically.

show more ...

missed some registers, kill'em!

millert@ ok

o) __progname aria;

millert@ ok.

Make mkdir -m 1777 foo and the like work. From how Netbsd/Freebsd do it.

more setmode() leaks -- kill 'em all

Fix a race where a dir might have been created after a stat call, but before
our mkdir