#
0f9891f1 |
| 24-May-2024 |
jsg <jsg@openbsd.org> |
remove unneeded includes; ok miod@
|
#
cf96265b |
| 10-Nov-2023 |
bluhm <bluhm@openbsd.org> |
Make ifq and ifiq interface MP safe.
Rename ifq_set_maxlen() to ifq_init_maxlen(). This function neither uses WRITE_ONCE() nor a mutex and is called before the ifq mutex is initialized. The new na
Make ifq and ifiq interface MP safe.
Rename ifq_set_maxlen() to ifq_init_maxlen(). This function neither uses WRITE_ONCE() nor a mutex and is called before the ifq mutex is initialized. The new name expresses that it should be used only during interface attach when there is no concurrency.
Protect ifq_len(), ifq_empty(), ifiq_len(), and ifiq_empty() with READ_ONCE(). They can be used without lock as they only read a single integer.
OK dlg@
show more ...
|
#
8d2c75e4 |
| 11-Mar-2022 |
mpi <mpi@openbsd.org> |
Constify struct cfattach.
|
#
4b1a56af |
| 09-Jan-2022 |
jsg <jsg@openbsd.org> |
spelling feedback and ok tb@ jmc@ ok ratchov@
|
#
0cae21bd |
| 10-Jul-2020 |
patrick <patrick@openbsd.org> |
Change users of IFQ_SET_MAXLEN() and IFQ_IS_EMPTY() to use the "new" API.
ok dlg@ tobhe@
|
#
63bcfa73 |
| 10-Jul-2020 |
patrick <patrick@openbsd.org> |
Change users of IFQ_DEQUEUE(), IFQ_ENQUEUE() and IFQ_LEN() to use the "new" API.
ok dlg@ tobhe@
|
#
46564b25 |
| 05-Jan-2020 |
jsg <jsg@openbsd.org> |
consistently uppercase pci product defines
ok mpi@
|
#
88a08f2a |
| 22-Jan-2017 |
dlg <dlg@openbsd.org> |
move counting if_opackets next to counting if_obytes in if_enqueue.
this means packets are consistently counted in one place, unlike the many and various ways that drivers thought they should do it.
move counting if_opackets next to counting if_obytes in if_enqueue.
this means packets are consistently counted in one place, unlike the many and various ways that drivers thought they should do it.
ok mpi@ deraadt@
show more ...
|
#
6a71aa30 |
| 13-Apr-2016 |
mpi <mpi@openbsd.org> |
G/C IFQ_SET_READY().
|
#
de6cd8fb |
| 25-Nov-2015 |
dlg <dlg@openbsd.org> |
replace IFF_OACTIVE manipulation with mpsafe operations.
there are two things shared between the network stack and drivers in the send path: the send queue and the IFF_OACTIVE flag. the send queue i
replace IFF_OACTIVE manipulation with mpsafe operations.
there are two things shared between the network stack and drivers in the send path: the send queue and the IFF_OACTIVE flag. the send queue is now protected by a mutex. this diff makes the oactive functionality mpsafe too.
IFF_OACTIVE is part of if_flags. there are two problems with that. firstly, if_flags is a short and we dont have any MI atomic operations to manipulate a short. secondly, while we could make the IFF_OACTIVE operates mpsafe, all changes to other flags would have to be made safe at the same time, otherwise a read-modify-write cycle on their updates could clobber the oactive change.
instead, this moves the oactive mark into struct ifqueue and provides an API for changing it. there's ifq_set_oactive, ifq_clr_oactive, and ifq_is_oactive. these are modelled on ifsq_set_oactive, ifsq_clr_oactive, and ifsq_is_oactive in dragonflybsd.
this diff includes changes to all the drivers manipulating IFF_OACTIVE to now use the ifsq_{set,clr_is}_oactive API too.
ok kettenis@ mpi@ jmatthew@ deraadt@
show more ...
|
#
32f46ff2 |
| 24-Nov-2015 |
mpi <mpi@openbsd.org> |
You only need <net/if_dl.h> if you're using LLADDR() or a sockaddr_dl.
|
#
0bd04349 |
| 16-Nov-2015 |
dlg <dlg@openbsd.org> |
rework vge_start to avoid IFQ_POLL
firstly, this checks for space in the tx ring before looking at the send queue. if there's no space, then IFF_OACTIVE is set and break.
if there's space use IFQ_D
rework vge_start to avoid IFQ_POLL
firstly, this checks for space in the tx ring before looking at the send queue. if there's no space, then IFF_OACTIVE is set and break.
if there's space use IFQ_DEQUEUE to pull a packet off. if we fail to encapsulate it, it gets dropped.
encap has been changed so the dmamaps the mbufs are loaded into are created with 7 segments instead of 32. this means we detect when the packet would overflow the tx descriptor at dmamap load time, rather than after we've looped over the segments writing them into the descriptor. we now use m_defrag to defrag the mbuf instead of allocating a new one and using m_copydata.
now if we have any encap error on the first mbuf, we no longer set IFF_OACTIVE and wait for an interrupt that never comes to clear it.
testing and (excellent) code review by richard proctor
show more ...
|
#
2b68f6ec |
| 14-Nov-2015 |
mpi <mpi@openbsd.org> |
Do not include <net/if_vlan_var.h> when it's not necessary.
Because of the VLAN hacks in mpw(4) this file still contains the definition of "struct ifvlan" which depends on <sys/refcnt.h> which in tu
Do not include <net/if_vlan_var.h> when it's not necessary.
Because of the VLAN hacks in mpw(4) this file still contains the definition of "struct ifvlan" which depends on <sys/refcnt.h> which in turns pull <sys/atomic.h>...
show more ...
|
#
3016beb6 |
| 25-Oct-2015 |
mpi <mpi@openbsd.org> |
arp_ifinit() is no longer needed.
|
#
f2a0e423 |
| 11-Sep-2015 |
stsp <stsp@openbsd.org> |
Make room for media types of the future. Extend the ifmedia word to 64 bits. This changes numbers of the SIOCSIFMEDIA and SIOCGIFMEDIA ioctls and grows struct ifmediareq.
Old ifconfig and dhclient b
Make room for media types of the future. Extend the ifmedia word to 64 bits. This changes numbers of the SIOCSIFMEDIA and SIOCGIFMEDIA ioctls and grows struct ifmediareq.
Old ifconfig and dhclient binaries can still assign addresses, however the 'media' subcommand stops working. Recompiling ifconfig and dhclient with new headers before a reboot should not be necessary unless in very special circumstances where non-default media settings must be used to get link and console access is not available.
There may be some MD fallout but that will be cleared up later.
ok deraadt miod with help and suggestions from several sharks attending l2k15
show more ...
|
#
db4dc9aa |
| 24-Jun-2015 |
mpi <mpi@openbsd.org> |
Increment if_ipackets in if_input().
Note that pseudo-drivers not using if_input() are not affected by this conversion.
ok mikeb@, kettenis@, claudio@, dlg@
|
#
c35f95b8 |
| 13-Apr-2015 |
mpi <mpi@openbsd.org> |
Now that if_input() set the receiving interface pointer on mbufs for us there's no need to do it in m_devget(9).
Stop passing an ``ifp'' will help for upcoming interface pointer -> index conversion.
Now that if_input() set the receiving interface pointer on mbufs for us there's no need to do it in m_devget(9).
Stop passing an ``ifp'' will help for upcoming interface pointer -> index conversion.
While here remove unused ``ifp'' argument from m_clget(9) and kill two birds^W layer violations in one commit.
ok henning@
show more ...
|
#
2c807ef4 |
| 08-Apr-2015 |
mpi <mpi@openbsd.org> |
Convert to if_input().
ok dlg@
|
#
21dab745 |
| 14-Mar-2015 |
jsg <jsg@openbsd.org> |
Remove some includes include-what-you-use claims don't have any direct symbols used. Tested for indirect use by compiling amd64/i386/sparc64 kernels.
ok tedu@ deraadt@
|
#
f79ee556 |
| 22-Dec-2014 |
tedu <tedu@openbsd.org> |
unifdef INET
|
#
9e6eaca1 |
| 22-Jul-2014 |
mpi <mpi@openbsd.org> |
Fewer <netinet/in_systm.h>
|
#
232dfaf1 |
| 21-Aug-2013 |
dlg <dlg@openbsd.org> |
get rid of the copy argument in m_devget that let you provide an alternative to bcopy since noone uses it.
while there use memcpy instead of bcopy because we know the memory cannot overlap.
ok henn
get rid of the copy argument in m_devget that let you provide an alternative to bcopy since noone uses it.
while there use memcpy instead of bcopy because we know the memory cannot overlap.
ok henning@ matthew@ mikeb@ deraadt@
show more ...
|
#
5e42885f |
| 07-Aug-2013 |
bluhm <bluhm@openbsd.org> |
Most network drivers include netinet/in_var.h, but apparently they don't have to. Just remove these include lines. Compiled on amd64 i386 sparc64; OK henning@ mikeb@
|
#
8ec68754 |
| 15-Mar-2013 |
brad <brad@openbsd.org> |
Rewrite receive filter handling and ioctl bits.
ok sthen@
|
#
7af3937f |
| 14-Mar-2013 |
brad <brad@openbsd.org> |
Add some missing bits for flow control support and enable it.
Tested with PCI and PCIe vge(4).
ok sthen@
|