[USER32] Introduce user32_vista and stubplement GetDpiForWindow() (#6208)

Add user32_vista.dll to introduce new NT6+ User32 features without changing the existing User32.dll when compiled as NT5.x.

[USER32] Introduce user32_vista and stubplement GetDpiForWindow() (#6208)

Add user32_vista.dll to introduce new NT6+ User32 features without changing the existing User32.dll when compiled as NT5.x. Also implements a stub for GetDpiForWindow(). The GetDpiForWindow() function will be required to Wine-sync common controls to modern Wine versions.

Changes:
Expose GetDpiForWindow() function and USER_DEFAULT_SCREEN_DPI to appropriate versions in winuser.h
Introduce a basic user32_vista library that can be expanded as needed.

show more ...

[NTGDI][FREETYPE] Simplify get_glyph_index_flagged (#6977)

Simplify code.
JIRA issue: CORE-9616
- Reduce one parameter of get_glyph_index_flagged function.

[NTGDI][FREETYPE] Unload font engine on system shut-down (#6955)

Check system integrity by explicitly
releasing the font engine.
JIRA issue: CORE-9616
- Use RTL_STATIC_LIST_HEAD against
g_Font

[NTGDI][FREETYPE] Unload font engine on system shut-down (#6955)

Check system integrity by explicitly
releasing the font engine.
JIRA issue: CORE-9616
- Use RTL_STATIC_LIST_HEAD against
g_FontListHead and
g_FontCacheListHead variables and
omit initialization of them.
- Implement FreeFontSupport function.
- Call FreeFontSupport in win32k!
DriverUnload function.
- Fix some usages of
CONTAINING_RECORD macro.

show more ...

[BOOTDATA][IMM32][NTUSER] Follow-up to #6961 (#6962)

JIRA issue: CORE-19320
- Delete "(brain-dead)".
- Fix "despite of" as "despite".
- Use "%S" instead of debugstr_w.

[BOOTDATA][IMM32][NTUSER] Set "LoadIMM" to zero

We set "LoadIMM" to zero in order to disable Cicero.
The name of "LoadIMM" is a brain-dead name. This name
means Cicero despite of its name (brain-dea

[BOOTDATA][IMM32][NTUSER] Set "LoadIMM" to zero

We set "LoadIMM" to zero in order to disable Cicero.
The name of "LoadIMM" is a brain-dead name. This name
means Cicero despite of its name (brain-dead).
They use a human-confusing name intentionally.

JIRA issue: CORE-19320

- Set HKLM\SOFTWARE\Microsoft\Windows NT\
CurrentVersion\IMM:LoadIMM to 0.
- Add warning comments to the brain-dead name "LoadIMM".

show more ...

[IMM32][NTUSER] Fix NtUserGetThreadState call of Imm32InquireIme

There was a mistake of parameter value for NtUserGetThreadState
call in Imm32InquireIme function. This affected the logon process.

J

[IMM32][NTUSER] Fix NtUserGetThreadState call of Imm32InquireIme

There was a mistake of parameter value for NtUserGetThreadState
call in Imm32InquireIme function. This affected the logon process.

JIRA issue: CORE-19320

- Replace THREADSTATE_ISWINLOGON2 with THREADSTATE_ISWINLOGON in
NtUserGetThreadState call in Imm32InquireIme function.
- Rename THREADSTATE_ISWINLOGON2 as THREADSTATE_UNKNOWN_0x10.
- Adapt NtUserGetThreadState to this change.

show more ...

[NTUSER] menu.c position fix to not obscure 'Close' (#6923)

CORE-19579

When IS_SYSTEM_MENU was redefined in https://github.com/reactos/reactos/commit/3ae0ccdcc,
this broke the logic here. So now

[NTUSER] menu.c position fix to not obscure 'Close' (#6923)

CORE-19579

When IS_SYSTEM_MENU was redefined in https://github.com/reactos/reactos/commit/3ae0ccdcc,
this broke the logic here. So now we restore the correctly working logic.

show more ...

[NTGDI] AlphaBlend/TransparentBlt: check whether the source DC is an INFO DC too (#6885)

Improve checks in AlphaBlend and TransparentBlt functions: check whether DCSrc is of DCTYPE_INFO also, to fai

[NTGDI] AlphaBlend/TransparentBlt: check whether the source DC is an INFO DC too (#6885)

Improve checks in AlphaBlend and TransparentBlt functions: check whether DCSrc is of DCTYPE_INFO also, to fail in that case properly too.
Spotted by PVS-Studio analysis.
Reference: https://pvs-studio.com/en/blog/posts/cpp/1122/.

show more ...

[USER32] Update Romanian (ro-RO) translation (#6704)

[NTUSER] Fix double click on title bar icon not closing window (#6697)

Patch by @I_Kill_Bugs

* [NTUSER] Fix double click on title bar icon not closing window

Improve MENU_TrackMenu handling.

[NTUSER] Fix double click on title bar icon not closing window (#6697)

Patch by @I_Kill_Bugs

* [NTUSER] Fix double click on title bar icon not closing window

Improve MENU_TrackMenu handling.

Guilty commit:0.4.15-dev-7750-gc17a654 https://github.com/reactos/reactos/commit/c17a6542ac329160ce627267babc8c7ec67b1e86

CORE-19492

show more ...

[NTUSER] Fix Skype and other programs installer windows not able to be moved with mouse by clicking on title bar (#6819)

Patch by @I_Kill_Bugs

Add condition into msgqueue along with filter testin

[NTUSER] Fix Skype and other programs installer windows not able to be moved with mouse by clicking on title bar (#6819)

Patch by @I_Kill_Bugs

Add condition into msgqueue along with filter testing to reject messages that are "NotForUs".
Also, do not set AcceptMessage to FALSE, but just keep msgDblClk and idSysPeek values and continue.

CORE-19487
CORE-19538

show more ...

[NTGDI][FREETYPE] Initial support of Surrogate Pairs and emojis (#6851)

Support emoji characters and minor characters.
JIRA issue: CORE-19030
NOTE: Not every emoji is supported yet (No ZWJ support

[NTGDI][FREETYPE] Initial support of Surrogate Pairs and emojis (#6851)

Support emoji characters and minor characters.
JIRA issue: CORE-19030
NOTE: Not every emoji is supported yet (No ZWJ support). Surrogate pairs only.
NOTE: This feature only works if the appropriate font is selected.
- Add IS_HIGH_SURROGATE and
IS_LOW_SURROGATE macros.
- Add Utf32FromSurrogatePair helper function
to convert a surrogate pair to a UTF-32 code
point.
- Convert the surrogate pairs in the text in
TextIntGetTextExtentPoint, IntGetTextDisposition,
and IntExtTextOutW functions.

show more ...

[NTGDI][FREETYPE] Check 'No transformation' for performance (#6850)

Slight performance improvement.
JIRA issue: CORE-15554
- Add bNoTransform variable.
- Check whether mat is identity matrix.
-

[NTGDI][FREETYPE] Check 'No transformation' for performance (#6850)

Slight performance improvement.
JIRA issue: CORE-15554
- Add bNoTransform variable.
- Check whether mat is identity matrix.
- If so, then don't do FT_Vector_Transform.

show more ...

[WIN32K:NTUSER] Fix NULL pointer dereference in MENU_HideSubPopups

Fixes CORE-19367.

[NTGDI][FREETYPE] Increase STACK_TEXT_BUFFER_SIZE (#6847)

Slight performance improvement. STACK_TEXT_BUFFER_SIZE = 100 was too small
for long text. This PR can reduce unnecessary buffer allocations

[NTGDI][FREETYPE] Increase STACK_TEXT_BUFFER_SIZE (#6847)

Slight performance improvement. STACK_TEXT_BUFFER_SIZE = 100 was too small
for long text. This PR can reduce unnecessary buffer allocations in NtGdiExtTextOutW
function.
JIRA issue: CORE-15554
- Change STACK_TEXT_BUFFER_SIZE to 512.

show more ...

[NTGDI][FREETYPE] Simplify code around bold/italic glyph caches (#6846)

Simplify and reduce font code.
JIRA issue: CORE-15554
- Don't treat bold/italic glyphs specially in font cache.
- Delete us

[NTGDI][FREETYPE] Simplify code around bold/italic glyph caches (#6846)

Simplify and reduce font code.
JIRA issue: CORE-15554
- Don't treat bold/italic glyphs specially in font cache.
- Delete useless IntGetBitmapGlyphNoCache function.

show more ...

[NTUSER] Remove some extra repaints/redraws (#6827)

Reposition logic and add Flags testing for RgnType == NULLREGION.
This was suggested by @HBelusca and approved by @I_Kill_Bugs

[USER32] defwnd.c only formatting, no functional change

For preparing a backport I do slightly improve the formatting:
- for the 2 SetScrollInfo() calls, that I do intend to port back
- fix last pla

[USER32] defwnd.c only formatting, no functional change

For preparing a backport I do slightly improve the formatting:
- for the 2 SetScrollInfo() calls, that I do intend to port back
- fix last place where we had mixed space and tab indentation in this file at the DefWindowProc signatures
- strip some exclamation marks in some dbg-prints
- improve the header
- strip a space at some rather long lines NtUserMessageCall()

show more ...

[NTUSER] Fix co_IntSetParent when calling on itself (#6365)

* Patch by @I_Kill_Bugs.

* Provide explanation for change.
CORE-9386

[USER32] Fix resource display of MSVC BI_BITFIELD 32-bit bitmaps. (#5942)

This specifically fixes Wordpad's Open and SaveAs dialog toolbars.

* Fix 16 bpp BI_BITFIELDS like 32 bpp was done.
* Add

[USER32] Fix resource display of MSVC BI_BITFIELD 32-bit bitmaps. (#5942)

This specifically fixes Wordpad's Open and SaveAs dialog toolbars.

* Fix 16 bpp BI_BITFIELDS like 32 bpp was done.
* Add BI_BITFIELDS byte count into bitmap_info_size return value.
* Account for GCC's windres.exe incorrect omission for BI_BITFIELDS DWORD's when processing 32-bpp bitmaps.
* Account for GCC's windres.exe failing with bitmaps with BI_BITFIELDS and bits per plane is 16
* Fix WARN message to show error on either 16-bpp or 32-bpp
* Correct comment regarding GCC compiled bitmaps with compression of BI_BITFIELD's to add 16 bits per plane

CORE-17005

show more ...

[NTUSER] Release modifier keys when deactivating message queue (#6754)

CORE-14768

[NTUSER] UserSetCursorPos(): Use an early return

Addendum to 76290a6 (0.4.15-dev-7889).

[WIN32SS] Introduce the NATIVE_REACTX define and disable some Dx calls (#6025)

The code itself isn't wrong but we're entirely missing the logic needed
to make it work. This leads to spontaneous cra

[WIN32SS] Introduce the NATIVE_REACTX define and disable some Dx calls (#6025)

The code itself isn't wrong but we're entirely missing the logic needed
to make it work. This leads to spontaneous crashes with video drivers and
various unity games.

show more ...

[NTUSER] Avoid sending superfluous WM_MOUSEMOVE messages (#6397)

Add a check so that mouse move messages are not generated unless
the mouse cursor X or Y position is changed.

This fixes extra mo

[NTUSER] Avoid sending superfluous WM_MOUSEMOVE messages (#6397)

Add a check so that mouse move messages are not generated unless
the mouse cursor X or Y position is changed.

This fixes extra mouse moves generated when clicking.
Patch by I_Kill_Bugs.

CORE-8394 CORE-18529 CORE-19422 CORE-19423

show more ...

[WIN32SS][USER32] Refactor USER32 callbacks (#6619)

Refactoring kernel-to-USER32 callback code.
Localize USER32 callback entry definitions.
JIRA issue: N/A
- Add header file win32ss/include/u32cb

[WIN32SS][USER32] Refactor USER32 callbacks (#6619)

Refactoring kernel-to-USER32 callback code.
Localize USER32 callback entry definitions.
JIRA issue: N/A
- Add header file win32ss/include/u32cb.h and use it to define the
USER32 callback entries.

show more ...