#
a8a5c538 |
| 03-Sep-2018 |
riastradh <riastradh@NetBSD.org> |
Rename min/max -> uimin/uimax for better honesty.
These functions are defined on unsigned int. The generic name min/max should not silently truncate to 32 bits on 64-bit systems. This is purely a n
Rename min/max -> uimin/uimax for better honesty.
These functions are defined on unsigned int. The generic name min/max should not silently truncate to 32 bits on 64-bit systems. This is purely a name change -- no functional change intended.
HOWEVER! Some subsystems have
#define min(a, b) ((a) < (b) ? (a) : (b)) #define max(a, b) ((a) > (b) ? (a) : (b))
even though our standard name for that is MIN/MAX. Although these may invite multiple evaluation bugs, these do _not_ cause integer truncation.
To avoid `fixing' these cases, I first changed the name in libkern, and then compile-tested every file where min/max occurred in order to confirm that it failed -- and thus confirm that nothing shadowed min/max -- before changing it.
I have left a handful of bootloaders that are too annoying to compile-test, and some dead code:
cobalt ews4800mips hp300 hppa ia64 luna68k vax acorn32/if_ie.c (not included in any kernels) macppc/if_gm.c (superseded by gem(4))
It should be easy to fix the fallout once identified -- this way of doing things fails safe, and the goal here, after all, is to _avoid_ silent integer truncations, not introduce them.
Maybe one day we can reintroduce min/max as type-generic things that never silently truncate. But we should avoid doing that for a while, so that existing code has a chance to be detected by the compiler for conversion to uimin/uimax without changing the semantics until we can properly audit it all. (Who knows, maybe in some cases integer truncation is actually intended!)
show more ...
|
#
5437fd46 |
| 03-Apr-2017 |
christos <christos@NetBSD.org> |
PR/52136: David Binderman: Rewrite loop to fix bounds check.
|
#
2e70da83 |
| 25-Jan-2017 |
jakllsch <jakllsch@NetBSD.org> |
Improve/fix igsfb(4) support for 15BPP.
Use howmany(depth, NBBY) instead of (depth >> 3), so that 15 bits maps to 2 bytes instead of 1.
While here, in a nearly-identical change, don't hard-code 8BP
Improve/fix igsfb(4) support for 15BPP.
Use howmany(depth, NBBY) instead of (depth >> 3), so that 15 bits maps to 2 bytes instead of 1.
While here, in a nearly-identical change, don't hard-code 8BPP into the CyberPro blitter.
show more ...
|
#
91061211 |
| 18-Nov-2009 |
macallan <macallan@NetBSD.org> |
Make colour depths higher than 8bit work in X. Now igsfb will switch to 16 or 32 bit colour when entering graphics mode, depending on available video memory and the given mode. While there re-initial
Make colour depths higher than 8bit work in X. Now igsfb will switch to 16 or 32 bit colour when entering graphics mode, depending on available video memory and the given mode. While there re-initialize the colour map etc. when leaving graphics mode.
show more ...
|
#
1049d3d6 |
| 18-Nov-2009 |
macallan <macallan@NetBSD.org> |
Write something more sane into the pixel format register - it's not pixel size in bytes although that works in 8 and 16 bit colour depth. While there do some magic number reduction.
|
#
d0b2c368 |
| 11-Nov-2009 |
macallan <macallan@NetBSD.org> |
add modeseting support. Now if there's a mode string in igsfb_devconfig the driver will try to use it if at all possible, otherwise fall back to the old hardcoded 1024x768x60 mode.
|
#
a2a38285 |
| 19-Oct-2007 |
ad <ad@NetBSD.org> |
machine/{bus,cpu,intr}.h -> sys/{bus,cpu,intr}.h
|
#
ccf4b50a |
| 05-Apr-2006 |
uwe <uwe@NetBSD.org> |
KNF: no parentheses around return value.
|
#
a31a2f7d |
| 05-Apr-2006 |
uwe <uwe@NetBSD.org> |
ANSI'ify.
|
#
31038cb7 |
| 23-Feb-2006 |
macallan <macallan@NetBSD.org> |
Add support for virtual consoles to igsfb. Works fine on a Krups, needs testing on other ports.
|
#
95e1ffb1 |
| 11-Dec-2005 |
christos <christos@NetBSD.org> |
merge ktrace-lwp.
|
#
520a24ea |
| 26-Nov-2004 |
uwe <uwe@NetBSD.org> |
Use standard uintN_t types instead of home-grown u_intN_t types.
|
#
a19b05b5 |
| 30-May-2003 |
uwe <uwe@NetBSD.org> |
Oops, do not disable coprocessor in igsfb_init_ext.
|
#
2866542a |
| 10-May-2003 |
uwe <uwe@NetBSD.org> |
Redo attachment to support proper cnattach. wscons on netwinder almost works now.
|
#
be3f67ca |
| 24-Sep-2002 |
uwe <uwe@NetBSD.org> |
Add some preliminary support for setting up the CyberPro in Netwinder. Setup sequence obtained from Krups OFW with some CyberPro-specific magic from Linux driver. The driver still has a lot of hardc
Add some preliminary support for setting up the CyberPro in Netwinder. Setup sequence obtained from Krups OFW with some CyberPro-specific magic from Linux driver. The driver still has a lot of hardcoded stuff, but it is useful enough to bring up wscons on netwinder.
XXX: Proper console attachment needs to be written (the driver was originally developed on sparc, where our approach to attaching console is totally different).
Caveat emptor!
show more ...
|