tests: Avoid non-portable 'echo -ARG'POSIX says that backslashes in the arguments to 'echo', as well asany use of 'echo -n' and 'echo -e', are non-portable; it recommendspeople should favor 'prin
tests: Avoid non-portable 'echo -ARG'POSIX says that backslashes in the arguments to 'echo', as well asany use of 'echo -n' and 'echo -e', are non-portable; it recommendspeople should favor 'printf' instead. This is definitely true wherewe do not control which shell is running (such as in makefile snippetsor in documentation examples). But even for scripts where werequire bash (and therefore, where echo does what we want by default),it is still possible to use 'shopt -s xpg_echo' to change bash'sbehavior of echo. And setting a good example never hurts when we arenot sure if a snippet will be copied from a bash-only script to ageneral shell script (although I don't change the use of non-portable\e for ESC when we know the running shell is bash).Replace 'echo -n "..."' with 'printf %s "..."', and 'echo -e "..."'with 'printf %b "...\n"', with the optimization that the %s/%bargument can be omitted if the string being printed is a strictliteral with no '%', '$', or '`' (we could technically also makethis optimization when there are $ or `` substitutions but wherewe can prove their results will not be problematic, but provingthat such substitutions are safe makes the patch less trivialcompared to just being consistent).In the qemu-iotests check script, fix unusual shell quotingthat would result in word-splitting if 'date' outputs a space.In test 051, take an opportunity to shorten the line.In test 068, get rid of a pointless second invocation of bash.CC: qemu-trivial@nongnu.orgSigned-off-by: Eric Blake <eblake@redhat.com>Message-id: 20170703180950.9895-1-eblake@redhat.comSigned-off-by: Max Reitz <mreitz@redhat.com>
show more ...
rocker: tests: don't need to specify master/self when setting vlans4.1 Linux kernel doesn't require specifying "master" or "self" when settingvlans on a port, so clean these up from the tests that
rocker: tests: don't need to specify master/self when setting vlans4.1 Linux kernel doesn't require specifying "master" or "self" when settingvlans on a port, so clean these up from the tests that use vlans.Signed-off-by: Scott Feldman <sfeldma@gmail.com>Message-id: 1435746792-41278-6-git-send-email-sfeldma@gmail.comSigned-off-by: Stefan Hajnoczi <stefanha@redhat.com>
rocker: update tests using hw-derived interface namesWith previous patch to support phy name attribute for each port, the OScan name port interfaces using the hw-derived name. So update rockerte
rocker: update tests using hw-derived interface namesWith previous patch to support phy name attribute for each port, the OScan name port interfaces using the hw-derived name. So update rockertests to use the new hw-derived interface names.Signed-off-by: Scott Feldman <sfeldma@gmail.com>Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>Message-id: 1433985681-56138-3-git-send-email-sfeldma@gmail.comSigned-off-by: Stefan Hajnoczi <stefanha@redhat.com>
rocker: add testsAdd some basic test for rocker to test L2/L3/L4 functionality. Requires anexternal test environment, simp, located here:https://github.com/scottfeldman/simpTo run tests, simp
rocker: add testsAdd some basic test for rocker to test L2/L3/L4 functionality. Requires anexternal test environment, simp, located here:https://github.com/scottfeldman/simpTo run tests, simp environment must be installed and a suitable VM image builtand installed with a Linux 3.18 (or greater) kernel with rocker driver supportenabled.Signed-off-by: Scott Feldman <sfeldma@gmail.com>Message-id: 1426306173-24884-8-git-send-email-sfeldma@gmail.comSigned-off-by: Stefan Hajnoczi <stefanha@redhat.com>