Revert "[USER32][LIBPNG] Support PNG/Vista icons (#7704)"

This reverts commit 7f4708479dd73dad32838b2329bb7215ea897433.

- PR was still in review;
- Doug has commit access himself.

[USER32][LIBPNG] Support PNG/Vista icons (#7704)

Add PNG (NT6/Vista+) support.
JIRA issue: CORE-18385
- Change libpng to add IMPORTLIB libpng.spec
to allow linking to it in USER32.
- Add code

[USER32][LIBPNG] Support PNG/Vista icons (#7704)

Add PNG (NT6/Vista+) support.
JIRA issue: CORE-18385
- Change libpng to add IMPORTLIB libpng.spec
to allow linking to it in USER32.
- Add code into mostly cursoricon.c to support
PNG icons.

show more ...

[NTUSER][USER32] Support GetWindow.GW_ENABLEDPOPUP (#7700)

JIRA issue: CORE-6920
- Make the return value of
NtUserCallHwnd a DWORD_PTR.
- Add DWP_GetEnabledPopup
helper function in
win32s

[NTUSER][USER32] Support GetWindow.GW_ENABLEDPOPUP (#7700)

JIRA issue: CORE-6920
- Make the return value of
NtUserCallHwnd a DWORD_PTR.
- Add DWP_GetEnabledPopup
helper function in
win32ss/user/ntuser/defwnd.c.
- Add code to NtUserCallHwnd for
HWND_ROUTINE_DWP_GETENABLEDPOPUP.
- Add code to GetWindow for
GW_ENABLEDPOPUP.
- Set last error in GetWindow and
IntGetWindow.

show more ...

Revert "[NTUSER] Enable SM_CXICON etc. settings from registry (#7679)" (#7682)

This reverts commit 3b3741c10af77bd54184e9d271206ac017e73b34 of #7679 .
It seems like the shell icon size is not the

Revert "[NTUSER] Enable SM_CXICON etc. settings from registry (#7679)" (#7682)

This reverts commit 3b3741c10af77bd54184e9d271206ac017e73b34 of #7679 .
It seems like the shell icon size is not the
system icon size.

The wide string L"Shell Small Icon Size" is detected in
shell32.dll and themeui.dll.
No L"Shell Small Icon Size" in win32k.sys found.
JIRA issue: CORE-12905

show more ...

[NTUSER] Enable SM_CXICON etc. settings from registry (#7679)

Improve usability.
JIRA issue: CORE-12905
- Add nIconSize and nSmallIconSize
values to SPIVALUES structure.
- Load "Shell Icon Siz

[NTUSER] Enable SM_CXICON etc. settings from registry (#7679)

Improve usability.
JIRA issue: CORE-12905
- Add nIconSize and nSmallIconSize
values to SPIVALUES structure.
- Load "Shell Icon Size" and "Shell
Small Icon Size" values from registry.
- Enable changing of SM_CXICON,
SM_CYICON, SM_CXSMICON, and
SM_CYSMICON settings.

show more ...

[REACTOS] Refresh old URLs (#7632)

URLs are getting old. We have to
update URLs for documentation
purpose.
JIRA issue: CORE-19963
- Refresh old URLs.
- Add " (DEAD_LINK)" labels
to dead link

[REACTOS] Refresh old URLs (#7632)

URLs are getting old. We have to
update URLs for documentation
purpose.
JIRA issue: CORE-19963
- Refresh old URLs.
- Add " (DEAD_LINK)" labels
to dead links.
- Use MS Learn links rather
than MSDN ones.
- Some dead links revived by
Web Archive.
- Don't change Wine Tests
and Wine Sync.
- Don't change 3rd party libraries.
- Don't append "redirected" labels.

show more ...

[USER32_APTEST][USER32] CopyImage improve regression test and function. (#7524)

CORE-19806 and CORE-17902.

* Follow-up of PR #6886 and commit d3ec7cd to remove hack.

[WIN32K:NTUSER] Check for NULL desktop window in co_IntProcessMouseMessage

[USER32] ordinals -> @

[NTUSER] IntSetTimer(): Use timer IDs range [256,32767] as on Windows (#7277)

Based on the Doug Lyons' test in #7087, I found that my previous fix stopped working partially. Or rather, it would only

[NTUSER] IntSetTimer(): Use timer IDs range [256,32767] as on Windows (#7277)

Based on the Doug Lyons' test in #7087, I found that my previous fix stopped working partially. Or rather, it would only work until the 32767 indexes were exhausted. It seems to me that the behavior of the bitfield has changed, because when I published the previous patch, it passed my tests.

- Bit array generates free ID cyclically, in the previous code after 32767 indexes expired the same index was returned, because of this the previous fix would stop working after expiration, so change the logic of calculating the next index.
- Change the index range to 256-32767 to match Windows, indexes 0-255 can theoretically be used as reserved for system purposes.

Addendum to fd327db20ff. CORE-9141

show more ...

[REACTOS] Use the ISO C and C++ conformant names: _wcsicmp, _stricmp

Stop using non-conforming wcsicmp, stricmp, strcasecmp

[WIN32K] Use UserRefObjectCo in co_UserFreeWindow

[WIN32K/USER] Fix callout object referencing in co_IntUpdateWindows

Move UserRefObjectCo, so that it covers co_IntSendMessage as well.
This caused a use-after-free during testing.

[WIN32K] ASSERT that all callout references have been cleaned up on thread exit

[WIN32SS:USER] Remove assignation of gpPrimaryGraphicsDevice (already done in EngpUpdateGraphicsDeviceList)

[USER32] Hackfix for CORE-17902 - The cursoricon (copyimage) that returns NULL to render - LR_COPYFROMRESOURCE (#6886)

* [USER32] Hackfix for CORE-17902 - The cursoricon (copyimage) that returns NUL

[USER32] Hackfix for CORE-17902 - The cursoricon (copyimage) that returns NULL to render - LR_COPYFROMRESOURCE (#6886)

* [USER32] Hackfix for CORE-17902 - The cursoricon (copyimage) that returns NULL to render - LR_COPYFROMRESOURCE

---------

Co-authored-by: Hermès BÉLUSCA - MAÏTO <hermes.belusca-maito@reactos.org>

show more ...

[WIN32K] Fix protection of USER heap

Create the section with PAGE_READWRITE, not PAGE_EXECUTE_READWRITE and map in user mode with PAGE_READONLY, not PAGE_EXECUTE_READ.
Original commit was ea5261f in

[WIN32K] Fix protection of USER heap

Create the section with PAGE_READWRITE, not PAGE_EXECUTE_READWRITE and map in user mode with PAGE_READONLY, not PAGE_EXECUTE_READ.
Original commit was ea5261f in 2006. The comments suggest that back then the heap code had issues with it, which is not the case anymore.

show more ...

[NTUSER] Fix unaligned access in co_IntSetWindowLongPtr

[USER32][NTUSER] Implement (NtUser)SetClassLongPtr(A/W)

[NTUSER] Fix a 64 bit bug in timer code

The return value of RtlFindClearBitsAndSet is an ULONG, assigning it to an ULONG_PTR will not sign extend it. The error value will stay 0xFFFFFFFF. Comparing

[NTUSER] Fix a 64 bit bug in timer code

The return value of RtlFindClearBitsAndSet is an ULONG, assigning it to an ULONG_PTR will not sign extend it. The error value will stay 0xFFFFFFFF. Comparing it to (UINT_PTR)-1 will sign extend and thus compare it to 0xFFFFFFFFFFFFFFFF on x64.
Also use NUM_WINDOW_LESS_TIMERS to initialize the bitmap, rather than the calculated size. This does not make a difference with the current value (32768), but if it was not the case, the bitmap would be larger than this, resulting in invalid bitmap indices being returned, which would cause bugs later on. Finally remove an ASSERT that can be triggered by tests.

show more ...

[NTUSER] Increase desktop heap size

Distinguish between the following 3 scenarios:
1. Interactive Winsta0, "Winlogon" desktop: use 128 KB
2. Interactive Winsta0, "Default" & other desktop: use 3 MB

[NTUSER] Increase desktop heap size

Distinguish between the following 3 scenarios:
1. Interactive Winsta0, "Winlogon" desktop: use 128 KB
2. Interactive Winsta0, "Default" & other desktop: use 3 MB (x86) / 20 MB (x64)
3. Non-interactive winsta: use 128 KB

This is what Windows 2003 uses for the interactive desktops on x86 and what Windows 7 uses for x64. Fixes desktop heap exhaustion during testing. The previous value was 512 KB for all desktops.
It doesn't handle the even smaller "Disconnected" desktop, which is only meaningful for RDP sessions and we don't use it anyway.
See comments in the file for references.