[USER32_APTEST][USER32] CopyImage improve regression test and function. (#7524)

CORE-19806 and CORE-17902.

* Follow-up of PR #6886 and commit d3ec7cd to remove hack.

[WIN32K:NTUSER] Check for NULL desktop window in co_IntProcessMouseMessage

[USER32] ordinals -> @

[NTUSER] IntSetTimer(): Use timer IDs range [256,32767] as on Windows (#7277)

Based on the Doug Lyons' test in #7087, I found that my previous fix stopped working partially. Or rather, it would only

[NTUSER] IntSetTimer(): Use timer IDs range [256,32767] as on Windows (#7277)

Based on the Doug Lyons' test in #7087, I found that my previous fix stopped working partially. Or rather, it would only work until the 32767 indexes were exhausted. It seems to me that the behavior of the bitfield has changed, because when I published the previous patch, it passed my tests.

- Bit array generates free ID cyclically, in the previous code after 32767 indexes expired the same index was returned, because of this the previous fix would stop working after expiration, so change the logic of calculating the next index.
- Change the index range to 256-32767 to match Windows, indexes 0-255 can theoretically be used as reserved for system purposes.

Addendum to fd327db20ff. CORE-9141

show more ...

[REACTOS] Use the ISO C and C++ conformant names: _wcsicmp, _stricmp

Stop using non-conforming wcsicmp, stricmp, strcasecmp

[WIN32K] Use UserRefObjectCo in co_UserFreeWindow

[WIN32K/USER] Fix callout object referencing in co_IntUpdateWindows

Move UserRefObjectCo, so that it covers co_IntSendMessage as well.
This caused a use-after-free during testing.

[WIN32K] ASSERT that all callout references have been cleaned up on thread exit

[WIN32SS:USER] Remove assignation of gpPrimaryGraphicsDevice (already done in EngpUpdateGraphicsDeviceList)

[USER32] Hackfix for CORE-17902 - The cursoricon (copyimage) that returns NULL to render - LR_COPYFROMRESOURCE (#6886)

* [USER32] Hackfix for CORE-17902 - The cursoricon (copyimage) that returns NUL

[USER32] Hackfix for CORE-17902 - The cursoricon (copyimage) that returns NULL to render - LR_COPYFROMRESOURCE (#6886)

* [USER32] Hackfix for CORE-17902 - The cursoricon (copyimage) that returns NULL to render - LR_COPYFROMRESOURCE

---------

Co-authored-by: Hermès BÉLUSCA - MAÏTO <hermes.belusca-maito@reactos.org>

show more ...

[WIN32K] Fix protection of USER heap

Create the section with PAGE_READWRITE, not PAGE_EXECUTE_READWRITE and map in user mode with PAGE_READONLY, not PAGE_EXECUTE_READ.
Original commit was ea5261f in

[WIN32K] Fix protection of USER heap

Create the section with PAGE_READWRITE, not PAGE_EXECUTE_READWRITE and map in user mode with PAGE_READONLY, not PAGE_EXECUTE_READ.
Original commit was ea5261f in 2006. The comments suggest that back then the heap code had issues with it, which is not the case anymore.

show more ...

[NTUSER] Fix unaligned access in co_IntSetWindowLongPtr

[USER32][NTUSER] Implement (NtUser)SetClassLongPtr(A/W)

[NTUSER] Fix a 64 bit bug in timer code

The return value of RtlFindClearBitsAndSet is an ULONG, assigning it to an ULONG_PTR will not sign extend it. The error value will stay 0xFFFFFFFF. Comparing

[NTUSER] Fix a 64 bit bug in timer code

The return value of RtlFindClearBitsAndSet is an ULONG, assigning it to an ULONG_PTR will not sign extend it. The error value will stay 0xFFFFFFFF. Comparing it to (UINT_PTR)-1 will sign extend and thus compare it to 0xFFFFFFFFFFFFFFFF on x64.
Also use NUM_WINDOW_LESS_TIMERS to initialize the bitmap, rather than the calculated size. This does not make a difference with the current value (32768), but if it was not the case, the bitmap would be larger than this, resulting in invalid bitmap indices being returned, which would cause bugs later on. Finally remove an ASSERT that can be triggered by tests.

show more ...

[NTUSER] Increase desktop heap size

Distinguish between the following 3 scenarios:
1. Interactive Winsta0, "Winlogon" desktop: use 128 KB
2. Interactive Winsta0, "Default" & other desktop: use 3 MB

[NTUSER] Increase desktop heap size

Distinguish between the following 3 scenarios:
1. Interactive Winsta0, "Winlogon" desktop: use 128 KB
2. Interactive Winsta0, "Default" & other desktop: use 3 MB (x86) / 20 MB (x64)
3. Non-interactive winsta: use 128 KB

This is what Windows 2003 uses for the interactive desktops on x86 and what Windows 7 uses for x64. Fixes desktop heap exhaustion during testing. The previous value was 512 KB for all desktops.
It doesn't handle the even smaller "Disconnected" desktop, which is only meaningful for RDP sessions and we don't use it anyway.
See comments in the file for references.

show more ...

[NTUSER] Optimize BroadcastSystemMessage a bit. Follow-up of #6884 (#7215)

Optimize BroadcastSystemMessage with Environment parameter.
Minimize processing when UserModeMsg->lParam is NULL and Kerne

[NTUSER] Optimize BroadcastSystemMessage a bit. Follow-up of #6884 (#7215)

Optimize BroadcastSystemMessage with Environment parameter.
Minimize processing when UserModeMsg->lParam is NULL and KernelModeMsg->message != WM_WININICHANGE
Make sure that we have a UNICODE_NULL within lParamMsg based on comment from @whindsaks

show more ...

[NTUSER] Address memory leak in co_WinPosSetWindowPos(). (#7284)

CORE-19723

[GDI32][NTUSER] Demote noisy debug prints

[NTUSER] Fix window not updating when scrollbars created and removed. (#7245)

* Revise conditions for window complete redraw.

CORE-19669

Co-authored-by: Oleg Dubinskiy <oleg.dubinskij30@gmail.

[NTUSER] Fix window not updating when scrollbars created and removed. (#7245)

* Revise conditions for window complete redraw.

CORE-19669

Co-authored-by: Oleg Dubinskiy <oleg.dubinskij30@gmail.com>
Co-authored-by: Vitaly Orekhov <7opex0@mail.ru>

show more ...

[NTUSER] IntSetTimer: Update HintIndex on each call (#7087)

* fix CORE-9141 - adding a change to IDEvent after each pass
If the first index is 0 the first returned ID will be 0x8000, which is fine.

[NTUSER] IntSetTimer: Update HintIndex on each call (#7087)

* fix CORE-9141 - adding a change to IDEvent after each pass
If the first index is 0 the first returned ID will be 0x8000, which is fine.
Co-authored-by: Joachim Henze <joachim.henze@reactos.org>

show more ...

[CMAKE] Use COMPILE_OPTIONS instead of superseded COMPILE_FLAGS

for set_source_files_properties().

[TRANSLATION] Improve Italian (it-IT) translation part 2 (#7248)

[NTUSER] Correctly store original unsnap position (#7244)

A small change before PR #5705 was merged caused a severe downgrade in the snap/unsnap handling. Win key handling should work correctly now.

[NTUSER] Correctly store original unsnap position (#7244)

A small change before PR #5705 was merged caused a severe downgrade in the snap/unsnap handling. Win key handling should work correctly now.

CORE-19165 CORE-19166

show more ...

[*_VISTA] Add/Improve version resources

[NTUSER] Rewrite Window Snap handling (#5705)

Fixes many Window Snap related bugs and uses the WS_EX2_VERTICALLYMAXIMIZED* styles to remember which edge it is snapped to.

The most significant cha

[NTUSER] Rewrite Window Snap handling (#5705)

Fixes many Window Snap related bugs and uses the WS_EX2_VERTICALLYMAXIMIZED* styles to remember which edge it is snapped to.

The most significant change is that GetWindowPlacement lies about the normal position when it is snapped, just like Windows.

CORE-19160 CORE-19165 CORE-19166

show more ...